Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

gpio: DummyPin + hub75_i8080 example #1769

Merged
merged 7 commits into from
Jul 15, 2024
Merged

Conversation

liebman
Copy link
Contributor

@liebman liebman commented Jul 7, 2024

Thank you for your contribution!

We appreciate the time and effort you've put into this pull request.
To help us review it efficiently, please ensure you've gone through the following checklist:

Submission Checklist 📝

  • I have updated existing examples or added new ones (if applicable).
  • I have used cargo xtask fmt-packages command to ensure that all changed code is formatted correctly.
  • My changes were added to the CHANGELOG.md in the proper section.
  • My changes are in accordance to the esp-rs API guidelines

Extra:

Pull Request Details 📖

DummyPin for when you don't want/have a real Pin.

Description

This PR adds DummyPin. Useful in cases where you have to supply a pin but it wont really be used, like esp_hal::lcd_cam::lcd::i8080::TxSixteenBits but you only want 14 bits. The included example does exactly this driving a HUB75 LED Matrx display using the lcd_cam peripheral.

Testing

Tested on esp32s3 with the new example.

@liebman
Copy link
Contributor Author

liebman commented Jul 7, 2024

The example does this:
image

@liebman liebman marked this pull request as ready for review July 7, 2024 17:09
Copy link
Contributor

@bjoernQ bjoernQ left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I can't test the example but the dummy pin is useful

Copy link
Contributor

@JurajSadel JurajSadel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, I also don't have a way of testing the example, I will ask, if someone from the team could give it a try. Thanks!

Copy link
Member

@MabezDev MabezDev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR! I like the dummy pin, but I think the example is probably not required. We won't be able to test it and it will likely bit rot over time. Could you remove it?

Copy link
Member

@MabezDev MabezDev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@liebman liebman requested a review from MabezDev July 15, 2024 12:30
@MabezDev MabezDev enabled auto-merge July 15, 2024 12:38
@MabezDev MabezDev added this pull request to the merge queue Jul 15, 2024
Merged via the queue into esp-rs:main with commit 10c900a Jul 15, 2024
31 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants